Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heads shuts down instead of rebooting #711

Closed
mkopec opened this issue Feb 20, 2024 · 4 comments · Fixed by linuxboot/heads#1704
Closed

Heads shuts down instead of rebooting #711

mkopec opened this issue Feb 20, 2024 · 4 comments · Fixed by linuxboot/heads#1704
Labels
bug Something isn't working heads novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen)
Milestone
NovaCustom NV4x (...

Comments

@mkopec
Copy link
Member

mkopec commented Feb 20, 2024

Device

NovaCustom NV4x ADL

Dasharo version

v0.9.0-rc3

Affected component(s) or functionality

Reboot

Brief summary

When issuing a reboot command in shell or via GUI, the machine shuts down instead of rebooting.

How reproducible

100%

How to reproduce

  • boot into Heads recovery shell
  • type in reboot
  • press Enter

Expected behavior

Laptop reboots

Actual behavior

Laptop shuts down

Screenshots

No response

Additional context

Doing OEM factory reset / re-ownership involves multiple resets, so powering off and waiting for a power button press is unexpected by the user.

Solutions you've tried

No response
@mkopec mkopec added the bug Something isn't working label Feb 20, 2024
@mkopec mkopec changed the title "Reboot" in Heads ends in a shutdown Heads shuts down instead of rebooting Feb 20, 2024
@tlaurion
Copy link

tlaurion commented Feb 20, 2024 •
edited
Loading

Might want to generalize this upstream:
linuxboot/heads@a1c13ff
linuxboot/heads@902866c

@mkopec mkopec added novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen) heads labels Feb 22, 2024
@miczyg1
Copy link
Contributor

miczyg1 commented Feb 23, 2024

These routines are only needed after EC firmware update. Otherwise regular reboot should be used AFAIK.

@mkopec
Copy link
Member Author

mkopec commented Feb 23, 2024

Correct, these are needed to reset the EC while it's in Scratch ROM to restore normal operation

macpijan added a commit to Dasharo/heads that referenced this issue Jun 20, 2024
@macpijan
nitropad-nx: use standard shutdown/reboot commands
0fb3886 
This commit effectively reverts commits a1c13ff and 902866c. There is
no need for this special EC-based poweroff command. See more details in
issue linked below.

Fixes: Dasharo/dasharo-issues#711

Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
macpijan added a commit to Dasharo/heads that referenced this issue Jun 20, 2024
@macpijan
nitropad-nx: use standard shutdown/reboot commands
fd98c8d 
This commit effectively reverts commits a1c13ff and 902866c. There is
no need for this special EC-based poweroff command. See more details in
issue linked below.

Fixes: Dasharo/dasharo-issues#711

Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan macpijan mentioned this issue Jun 20, 2024
Merged
@macpijan
Copy link
Contributor

Included in: https://docs.dasharo.com/variants/novacustom_nv4x_adl/releases_heads/#v091-2024-06-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working heads novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen)
Projects
None yet
Milestone
NovaCustom NV4x (coreboot + heads) v0...
Development

Successfully merging a pull request may close this issue.

nitropad-nx: use standard shutdown/reboot commands Dasharo/heads
5 participants
@tlaurion @mkopec @macpijan @miczyg1 @BeataZdunczyk