clevo/ec-flash.sh: add #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
mkopec
reviewed
Nov 2, 2022
|
|
||
| update_ec() { | ||
| echo "Getting EC firmware update..." | ||
| cp $EC_UPDATE_PATH /tmp/ecupdate.rom |
There was a problem hiding this comment.
Why do we need to make this copy?
There was a problem hiding this comment.
@mkopec I was also wondering. It is just a copy from DTS ec_transition script, leaving just the EC update part.
@TomaszAIR CC
Maybe there was a reason in the original script, I'm not sure. I just quickly stripped it off.
There was a problem hiding this comment.
This is because we stored hash values hardcoded in the following form (as in other, similar script)
EC_HASH="123123123123123 /tmp/ecupdate.rom
so we checked hash against file in specific path.
|
@macpijan is this PR still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maciej Pijanowski maciej.pijanowski@3mdeb.com