Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: autoupdate hooks #182

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 5208a3e to 23fa584 Compare October 21, 2024 21:41
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 0ccc373 to 6aa0228 Compare November 4, 2024 21:57
@m-iwanicki m-iwanicki changed the base branch from main to develop November 20, 2024 10:41
@m-iwanicki
Copy link
Contributor

@PLangowski maybe we should disable multiline indent fix? Or even check? There are too many problems with it and every update it's something different.
Checkout this branch and run pre-commit run -a to see what I mean.
And maybe we should stick to 4 spaces indent as I don't think anyone uses dynamic one based on position of "

Minimal testing example:

  1. Create test_git.bb file containing e.g.:

    SUMMARY = "test"
    HOMEPAGE = "https://example.org"
    LICENSE = "CLOSED"
    
    DEPENDS += " \
        openssl \
        flashrom \
        "
    
    SRC_URI = "file://test"
  2. Run pre-commit run oelint-adv --files test_git.bb

  3. Check errors & diff

    meta-dts/test_git.bb:7:warning:oelint.vars.multilineident:On a multiline assignment, line indent is desirable. 0 set, 4 desirable [branch:true]
    
    --- test_git.bb 2024-11-20 12:37:13.631632109 +0100
    +++ test_git.bb.2       2024-11-20 12:37:11.922653875 +0100
    @@ -5,6 +5,6 @@
     DEPENDS += " \
         openssl \
    -    flashrom \
    -    "
    +flashrom \
    +   "
     
     SRC_URI = "file://test"

Not only that, but sometimes it also removes space between e.g.

-flashrom \
+flashrom\

not sure why or when.

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.4.0...v5.0.0)
- [github.com/adrienverge/yamllint: v1.32.0 → v1.35.1](adrienverge/yamllint@v1.32.0...v1.35.1)
- [github.com/igorshubovych/markdownlint-cli: v0.36.0 → v0.43.0](igorshubovych/markdownlint-cli@v0.36.0...v0.43.0)
- [github.com/talos-systems/conform: v0.1.0-alpha.27 → v0.1.0-alpha.30](siderolabs/conform@v0.1.0-alpha.27...v0.1.0-alpha.30)
- [github.com/priv-kweihmann/oelint-adv: 5.7.2 → 6.6.1](priv-kweihmann/oelint-adv@5.7.2...6.6.1)
- [github.com/codespell-project/codespell: v2.2.5 → v2.3.0](codespell-project/codespell@v2.2.5...v2.3.0)
- [github.com/3mdeb/hooks: v0.1.2 → v0.1.3](3mdeb/hooks@v0.1.2...v0.1.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant