Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform configs should include expected power state for flashing #15

Closed
mkopec opened this issue Mar 1, 2024 · 2 comments · Fixed by #42
Closed

Platform configs should include expected power state for flashing #15

mkopec opened this issue Mar 1, 2024 · 2 comments · Fixed by #42
Labels
enhancement New feature or request
Milestone
v0.6.0

Comments

@mkopec
Copy link
Member

mkopec commented Mar 1, 2024 •
edited
Loading

Platforms need to be in a certain state for flashing. Platform configs should reflect that.

Platform configs should specify a power state for flashing: OFF (power completely removed), G3 (mechanical off, power still provided), S5 (soft off). The RTE should control the platform (sonoff, relay, power button, SPI voltage etc) based on those inputs.
@mkopec mkopec changed the title Platform configs should include expected power state Platform configs should include expected power state for flashing Mar 1, 2024
@SergiiDmytruk SergiiDmytruk mentioned this issue Jun 8, 2024
Closed
@macpijan
Copy link
Contributor

@mkopec

Currently, we have init_on flag which indicates whether the power should be applied: https://github.com/Dasharo/osfv-scripts/blob/main/osfv_cli/osfv_cli/models/V1210.yml#L13

By default it is not applied: https://github.com/Dasharo/osfv-scripts/blob/main/osfv_cli/osfv_cli/rte.py#L197

Do you suggest that we should instead rename this option to power state and provide 3 options (OFF, G3, S5), which will drive the power sequencing as needed?

@macpijan macpijan added this to the v0.5.0 milestone Jun 10, 2024
@macpijan macpijan added the enhancement New feature or request label Jun 10, 2024
@pietrushnic pietrushnic mentioned this issue Jun 10, 2024
Closed
macpijan added a commit that referenced this issue Jun 10, 2024
@macpijan
osfv_cli: introduce flash power state param
38c1a19 
Fixes: #37
Fixes: #15

Tested:

* MSI Z690

DUT model retrieved from snipeit: MSI PRO Z690-A DDR4
Found Macronix flash chip "MX25U25635F" (32768 kB, SPI) on linux_spi.

* Protectli V1410

DUT model retrieved from snipeit: V1410
Found Winbond flash chip "W25Q128.V" (16384 kB, SPI) on ch341a_spi.

* Protectli VP6650

DUT model retrieved from snipeit: VP6650
Found Macronix flash chip "MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F" (16384 kB, SPI) on linux_spi.

* PC Engines APU3

DUT model retrieved from snipeit: APU3
Found Winbond flash chip "W25Q64JV-.Q" (8192 kB, SPI) on linux_spi.

* PC Engines APU4

DUT model retrieved from snipeit: APU4
Found Winbond flash chip "W25Q64JV-.Q" (8192 kB, SPI) on linux_spi.

* Protecli VP46XX - none in lab currently fully connected

Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan macpijan mentioned this issue Jun 10, 2024
Merged
@macpijan
Copy link
Contributor

Please see the referenced PR if that is what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

osfv_cli: introduce flash power state param Dasharo/osfv-scripts
2 participants
@mkopec @macpijan