Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argon2-threads): fix cmake flag to disable multithreading #11

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

ni0ki
Copy link

@ni0ki ni0ki commented Sep 8, 2021

Description

(This is a backport of antelle@c552be9)

Disable multi-threading when compiling Argon2 library. The existing compilation flags (-DARGON_JS) was wrong / unused, and should be replaced by -DARGON_NO_THREADS.

What for ?

Because of this wrong flag, the WASM code was spawning Web Workers to handle multi-threading.

@fellowseb
Copy link

Maybe directly add a commit to increment the package.json version field ?

@ni0ki ni0ki merged commit 50613e6 into master Sep 15, 2021
@ni0ki ni0ki deleted the fix/EXTENSION-16731-disable-argon2-multithreading branch September 15, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants