Correct bug when title parameter is missing from credentials (#51)

Correct bug #42 that happens when the title parameter is missing from the credentials. The fix is to use the url instead of the title parameter when the latest is missing.
Dashlane · Feb 28, 2023 · ffa356e · ffa356e
2 parents ed5bfbf + 24c0258
commit ffa356e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/middleware/getPasswords.ts b/src/middleware/getPasswords.ts
@@ -130,7 +130,9 @@ export const getPassword = async (params: GetCredential): Promise<void> => {
     switch (params.output || 'clipboard') {
         case 'clipboard':
             clipboard.writeSync(selectedCredential.password);
-            console.log(`🔓 Password for "${selectedCredential.title}" copied to clipboard!`);
+            console.log(
+                `🔓 Password for "${selectedCredential.title || selectedCredential.url || 'N\\C'}" copied to clipboard!`
+            );
 
             if (selectedCredential.otpSecret) {
                 const token = authenticator.generate(selectedCredential.otpSecret);

diff --git a/src/types.ts b/src/types.ts
@@ -117,7 +117,7 @@ export interface SecureNoteTransactionContent {
 }
 
 export interface VaultCredential {
-    title: string;
+    title?: string;
     email?: string;
     login?: string;
     password: string;
@@ -152,7 +152,7 @@ export class PrintableVaultCredential {
 
     toString(): string {
         return (
-            this.vaultCredential.title.trim() +
+            (this.vaultCredential.title?.trim() || this.vaultCredential.url || 'N\\C') +
             ' - ' +
             (this.vaultCredential.email?.trim() ||
                 this.vaultCredential.login?.trim() ||