Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email validation in dcli sync is too restrictive. #196

Closed
j-at-ch opened this issue Nov 8, 2023 · 3 comments · Fixed by #197
Closed

Email validation in dcli sync is too restrictive. #196

j-at-ch opened this issue Nov 8, 2023 · 3 comments · Fixed by #197
Assignees
@Mikescops
Labels
bug Something isn't working

Comments

@j-at-ch
Copy link

j-at-ch commented Nov 8, 2023

Describe the bug
Email validation in dcli sync seems to be too restrictive, so that legitimate emails (including my login email) are deemed invalid by the cli.

To Reproduce
Steps to reproduce the behavior:

  1. In terminal command: dcli sync
    $ ? Please enter your email address:
  2. Respond with: bob@company.health
    >> Not a valid email address

Expected behavior
For the email with a .health suffix to be recognised.

Environment:

  • OS: MacOS
  • Version: Ventura 13.5
@j-at-ch j-at-ch added the bug Something isn't working label Nov 8, 2023
@Mikescops
Copy link
Member

Thanks for reporting! I'll have a look 👍

@Mikescops Mikescops self-assigned this Nov 8, 2023
@Mikescops Mikescops mentioned this issue Nov 24, 2023
Merged
Mikescops added a commit that referenced this issue Nov 24, 2023
@Mikescops
Fix email regex too restrictive (#197)
c90ba53 
Fix #196
@j-at-ch
Copy link
Author

j-at-ch commented Nov 24, 2023

Thanks for this @Mikescops!

@Mikescops
Copy link
Member

Fixed in the latest update 1.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mikescops Mikescops

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix email regex too restrictive Dashlane/dashlane-cli
2 participants
@Mikescops @j-at-ch