Add Master Password in OS keychain #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien-Leos
force-pushed
the
feature/move-master-password-derivate-to-OS-vault
branch
3 times, most recently
from
961d075
to
4543897
Compare
Julien-Leos
requested review from
PLhery,
Mikescops and
jboillot
and removed request for
Mikescops
jboillot
force-pushed
the
feature/move-master-password-derivate-to-OS-vault
branch
from
4543897
to
ac04a84
Compare
PLhery
approved these changes
Apr 13, 2022
jboillot
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows user to retry prompting his master password in case we can't decrypt the Setting transaction.