Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint CI trigger #261

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix lint CI trigger #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Run tests & lint

on: [push]
on:
push:
branches:
- master
pull_request:
branches:
- master

jobs:
build:
Expand Down
14 changes: 10 additions & 4 deletions src/modules/database/vaultContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ export const getVaultContent = (path: string): string => {
};

export const findVaultContent = (vaultContent: VaultContent, parsedPath: ParsedPath): string => {
let filteredVaultContent: VaultContent = {
const filteredVaultContent: VaultContent = {
credentials: [],
notes: [],
secrets: []
secrets: [],
};

if (parsedPath.title) {
Expand All @@ -75,12 +75,18 @@ export const findVaultContent = (vaultContent: VaultContent, parsedPath: ParsedP
}

if (parsedPath.itemId) {
filteredVaultContent.credentials = vaultContent.credentials.filter((credential) => credential.id === parsedPath.itemId);
filteredVaultContent.credentials = vaultContent.credentials.filter(
(credential) => credential.id === parsedPath.itemId
);
filteredVaultContent.notes = vaultContent.notes.filter((note) => note.id === parsedPath.itemId);
filteredVaultContent.secrets = vaultContent.secrets.filter((secret) => secret.id === parsedPath.itemId);
}

if (filteredVaultContent.credentials.length === 0 && filteredVaultContent.notes.length === 0 && filteredVaultContent.secrets.length === 0) {
if (
filteredVaultContent.credentials.length === 0 &&
filteredVaultContent.notes.length === 0 &&
filteredVaultContent.secrets.length === 0
) {
throw new Error(`No matching item found for "${parsedPath.itemId ?? parsedPath.title ?? ''}"`);
}

Expand Down
Loading