Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to Rust deps and Yarn #73

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Migration to Rust deps and Yarn #73

merged 1 commit into from
Mar 5, 2023

Conversation

Mikescops
Copy link
Member

This PR tries to solve multiple issues with dependencies we have:

  • remove keytar as it is now unmaintained (GitHub stopped the Atom project and all related dependencies)
  • move argon2 to Rust (faster and also no more node-gyp)
  • moved to yarn to be able to support multiple architectures
  • rework the different integrations of the modules in the code

@Mikescops Mikescops added the features New feature or request label Mar 5, 2023
@Mikescops Mikescops requested a review from jboillot March 5, 2023 16:04
@Mikescops Mikescops self-assigned this Mar 5, 2023
@Mikescops Mikescops force-pushed the feature/migration-to-rust branch 2 times, most recently from 39816b9 to cc5c9f9 Compare March 5, 2023 17:09
@Mikescops Mikescops changed the title Draft: Migration to Rust deps and Yarn Migration to Rust deps and Yarn Mar 5, 2023
@Mikescops
Copy link
Member Author

I tested on Windows and it works well except for the reported clipboardy bug

/snapshot/dashlane-cli/node_modules/clipboardy/fallbacks/windows/clipboard_x86_64.exe ENOENT

but this is already reported in #45

@jboillot
Copy link
Collaborator

jboillot commented Mar 5, 2023

Re-add package-lock.json file.

@jboillot
Copy link
Collaborator

jboillot commented Mar 5, 2023

I think we should correct README.md file about how to install dependencies, from npm ci to yarn install --frozen-lockfile.
Can you confirm that?

@Mikescops
Copy link
Member Author

Closes #72

@Mikescops Mikescops merged commit 6f2c279 into master Mar 5, 2023
@Mikescops Mikescops deleted the feature/migration-to-rust branch March 5, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jboillot jboillot jboillot approved these changes

Assignees

@Mikescops Mikescops

Labels
features New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikescops @jboillot