-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devices): add list and remove devices commands #96
Conversation
a215a30
to
dfd2501
Compare
dfd2501
to
a1445ba
Compare
|
||
export async function listAllDevices(options: { json: boolean }) { | ||
const { secrets, deviceConfiguration } = await connectAndPrepare({ autoSync: false }); | ||
if (!deviceConfiguration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think you need this, the connectAndPrepare will register the device if it doesn't exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix the typings of connectAndPrepare
then because right now it returns a nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok my bad, then leave it, i will take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of small comments added
Co-authored-by: Corentin Mors <corentin@dashlane.com>
List and remove devices
Why ?
I often ends up having thousands of connected devices connected to my tests account.
Sometimes, i need to test device-removal workflows and I do not want to manually scroll and find which device to remove from the back office.
Also added