Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moto decorator usage is order-dependent #3035

Closed
amarjandu opened this issue May 4, 2021 · 2 comments
Closed

Moto decorator usage is order-dependent #3035

amarjandu opened this issue May 4, 2021 · 2 comments
Assignees
@hannes-ucsc
Labels
blocked [process] Blocked by external dependency bug [type] A defect preventing use of the system as specified debt [type] A defect incurring continued engineering cost no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team test [subject] Unit and integration test code

Comments

@amarjandu
Copy link
Contributor

Its possible that the ordering of multiple moto @mock decorators causes issues with how a response callback is handled from within Moto, we should be aware of this when working with the library to mock out AWS functionality in unittests.

See getmoto/moto#3790
@amarjandu amarjandu added orange [process] Done by the Azul team stub labels May 4, 2021
@melainalegaspi melainalegaspi changed the title Moto decorator usage is order dependent Moto decorator usage is order-dependent May 4, 2021
@melainalegaspi melainalegaspi added debt [type] A defect incurring continued engineering cost test [subject] Unit and integration test code blocked [process] Blocked by external dependency and removed stub labels May 4, 2021
dsotirho-ucsc pushed a commit that referenced this issue May 20, 2021
@amarjandu @dsotirho-ucsc
[R 1/9] Update moto to 2.0.6 (#1718)
c411f75 
Update requirements
Add FIXME (#3035)
@melainalegaspi melainalegaspi added the bug [type] A defect preventing use of the system as specified label Sep 30, 2021
@hannes-ucsc hannes-ucsc self-assigned this Oct 8, 2022
@hannes-ucsc
Copy link
Member

Upstream blocker is resolved.

@hannes-ucsc hannes-ucsc mentioned this issue Oct 10, 2022
Merged
71 tasks
@hannes-ucsc hannes-ucsc added the no demo [process] Not to be demonstrated at the end of the sprint label Oct 11, 2022
@hannes-ucsc
Copy link
Member

hannes-ucsc commented Oct 11, 2022 •
edited
Loading

PR #4562 removes the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannes-ucsc hannes-ucsc

Labels
blocked [process] Blocked by external dependency bug [type] A defect preventing use of the system as specified debt [type] A defect incurring continued engineering cost no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team test [subject] Unit and integration test code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amarjandu @hannes-ucsc @melainalegaspi