Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdr_anvil's fetch_bundle lacks test coverage #5046

Closed
13 of 14 tasks
dsotirho-ucsc opened this issue Mar 13, 2023 · 14 comments
Closed
13 of 14 tasks

tdr_anvil's fetch_bundle lacks test coverage #5046

dsotirho-ucsc opened this issue Mar 13, 2023 · 14 comments
Assignees
Labels
+ [priority] High debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team spike:5 [process] Spike estimate of five points test [subject] Unit and integration test code

Comments

@dsotirho-ucsc
Copy link
Contributor

dsotirho-ucsc commented Mar 13, 2023

…due to TinyQuery not supporting the WITH clause

  • Security design review completed; the Resolution of this issue does not
    • … affect authentication; for example:
      • OAuth 2.0 with the application (API or Swagger UI)
      • Authentication of developers with Google Cloud APIs
      • Authentication of developers with AWS APIs
      • Authentication with a GitLab instance in the system
      • Password and 2FA authentication with GitHub
      • API access token authentication with GitHub
      • Authentication with
    • … affect the permissions of internal users like access to
      • Cloud resources on AWS and GCP
      • GitLab repositories, projects and groups, administration
      • an EC2 instance via SSH
      • GitHub issues, pull requests, commits, commit statuses, wikis, repositories, organizations
    • … affect the permissions of external users like access to
      • TDR snapshots
    • … affect permissions of service or bot accounts
      • Cloud resources on AWS and GCP
    • … affect audit logging in the system, like
      • adding, removing or changing a log message that represents an auditable event
      • changing the routing of log messages through the system
    • … affect monitoring of the system
    • … ~introduce a new software dependency like tdr_anvil's fetch_bundle lacks test coverage #5046 (comment)
      • Python packages on PYPI
      • Command-line utilities
      • Docker images
      • Terraform providers
    • … add an interface that exposes sensitive or confidential data at the security boundary
    • … affect the encryption of data at rest
    • … require persistence of sensitive or confidential data that might require encryption at rest
    • … require unencrypted transmission of data within the security boundary
    • … affect the network security layer; for example by
      • modifying, adding or removing firewall rules
      • modifying, adding or removing security groups
      • changing or adding a port a service, proxy or load balancer listens on
  • Documentation on any unchecked boxes is provided in comments below
@dsotirho-ucsc dsotirho-ucsc added the orange [process] Done by the Azul team label Mar 13, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 13, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 14, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 14, 2023
@dsotirho-ucsc dsotirho-ucsc self-assigned this Mar 15, 2023
@dsotirho-ucsc
Copy link
Contributor Author

@danielsotirhos to fix title & description.

@dsotirho-ucsc dsotirho-ucsc changed the title TinyQuery does not support the WITH clause Lacking test coverage of tdr_anvil's fetch_bundle() Mar 15, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 15, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 15, 2023
@dsotirho-ucsc dsotirho-ucsc changed the title Lacking test coverage of tdr_anvil's fetch_bundle() tdr_anvil's fetch_bundle lacks test coverage Mar 16, 2023
@dsotirho-ucsc dsotirho-ucsc added debt [type] A defect incurring continued engineering cost test [subject] Unit and integration test code labels Mar 16, 2023
@dsotirho-ucsc dsotirho-ucsc removed their assignment Mar 16, 2023
@dsotirho-ucsc dsotirho-ucsc added the - [priority] Medium label Mar 16, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 16, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 17, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 18, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 21, 2023
dsotirho-ucsc added a commit that referenced this issue Mar 27, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 4, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 4, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 5, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 5, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 7, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 7, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 12, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 12, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 18, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 18, 2023
dsotirho-ucsc added a commit that referenced this issue Apr 20, 2023
@hannes-ucsc hannes-ucsc removed their assignment Jan 20, 2024
@hannes-ucsc
Copy link
Member

Security review: The first PR (#5833) adds a Docker image. The image is built on GitHub Actions and pushed to GitHub's registry at ghcr.io. Like all other images used by Azul, it is mirrored to ECR and scanned by Amazon Inspector. Docker Scout reports 1 M and 27 L vulnerabilities.

image

Inspector reports 1 H and 1 M.

image

I've created #5905 to ensure that the image is maintained as part of the biweekly upgrades.

@hannes-ucsc hannes-ucsc added the demo [process] To be demonstrated at the end of the sprint label Jan 29, 2024
@hannes-ucsc
Copy link
Member

hannes-ucsc commented Jan 29, 2024

For demo show increased unit test coverage on codecov.io.

@nadove-ucsc nadove-ucsc added demo blocked [process] Demo is blocked by ongoing work demoed [process] Successfully demonstrated to team and removed demo blocked [process] Demo is blocked by ongoing work labels Feb 6, 2024
@nadove-ucsc
Copy link
Contributor

Follow-up work: #5934, #5935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+ [priority] High debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team spike:5 [process] Spike estimate of five points test [subject] Unit and integration test code
Projects
None yet
Development

No branches or pull requests

4 participants