Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

ID-1072 Investigate Invalid Nonce Errors #235

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tlangs
Copy link
Collaborator

@tlangs tlangs commented Feb 7, 2024

https://broadworkbench.atlassian.net/browse/ID-1072

Google Datastore is eventually consistent, and the get method in the NDB Client does not wait for eventual consistency. I'm guessing this is the reason why, the more Bond replicas running, the more we see Invalid nonce errors.

NDB might be doing the right thing, so lets just add logging to try and diagnose the problem.


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary.
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment
  • Release to production - Releasing to prod is a manual process (see instructions to release to prod). Either do this now or create a ticket and schedule the release.

@tlangs tlangs changed the title ID-1072 Fix Invalid Nonce Errors ID-1072 Investigate Invalid Nonce Errors Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants