Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1396 Cromwell client allow additional properties #227

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Conversation

aednichols
Copy link
Contributor

@aednichols aednichols commented Jan 4, 2024

Adopts JAR from broadinstitute/cromwell#7352

https://lz7388ada396994bb48ea5c87a02eed673689c82c2af423d03.servicebus.windows.net/terra-app-6e61e365-081b-4511-820a-c6c29dc882da-cd9ecb9e-936f-4027-b05b-05be7ab3a972/cbas/status

Before:

{
	"ok": true,
	"systems": {
		"sam": {
			"ok": true,
			"messages": [
				"class SystemStatus {\n    ok: true\n    systems: {GoogleGroups=class SubsystemStatus {\n        ok: true\n        messages: null\n    }, GooglePubSub=class SubsystemStatus {\n        ok: true\n        messages: null\n    }, GoogleIam=class SubsystemStatus {\n        ok: true\n        messages: null\n    }, Database=class SubsystemStatus {\n        ok: true\n        messages: null\n    }}\n}"
			]
		},
		"leonardo": {
			"ok": true,
			"messages": [
				"class SystemStatus {\n    ok: true\n    systems: {Sam={ok=true, messages=null}, Database={ok=true, messages=null}}\n    additionalProperties: null\n}"
			]
		}
	}
}

After:

{
	"ok": true,
	"systems": {
		"cromwell": {
			"ok": true,
			"messages": [
				"Cromwell was reachable"
			]
		},
		"sam": {
			"ok": true,
			"messages": [
				"class SystemStatus {\n    ok: true\n    systems: {GoogleGroups=class SubsystemStatus {\n        ok: true\n        messages: null\n    }, GooglePubSub=class SubsystemStatus {\n        ok: true\n        messages: null\n    }, GoogleIam=class SubsystemStatus {\n        ok: true\n        messages: null\n    }, Database=class SubsystemStatus {\n        ok: true\n        messages: null\n    }}\n}"
			]
		},
		"leonardo": {
			"ok": true,
			"messages": [
				"class SystemStatus {\n    ok: true\n    systems: {Sam={ok=true, messages=null}, Database={ok=true, messages=null}}\n    additionalProperties: null\n}"
			]
		}
	}
}

@aednichols aednichols requested a review from a team as a code owner January 4, 2024 23:28
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@aednichols aednichols merged commit f8934ee into main Jan 8, 2024
9 checks passed
@aednichols aednichols deleted the aen_wx_1396 branch January 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants