[DUOS-1815][risk=no] New Researcher Profile Page

[connorlbark]

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-1815

Notes:

• Calls new PUT /api/user/me endpoint on profile page - endpoint created at [DUOS-1815][risk=low] Add update own user properties endpoint consent#1649 , so must use that backend branch for testing.
• Changes the Institution and Signing Official search bars to allow freetext entry (press enter after searching) separately from selecting a pre-existing institution. If set, will update suggestedInstitution/suggestedSigningOfficial instead of sending the ids.
• The page is different if you are a research or a signing official. Signing officials cannot change their institution once set. Researchers may change their institution and signing officials anytime.

---

Have you read Terra's Contributing Guide lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[lu-c]

Hi!

I'm seeing some differences in the branch between the mock ups - Am I running it wrong?

1. "An eRA Commons ID will be required to submit a dar." <-- The eRA commons id is a link in the mock up, but seems like just text here
2. The checklist with "what are you trying to do" isn't showing up - Reading the ticket, I think it might be out of scope?

[connorlbark]

Hi!

I'm seeing some differences in the branch between the mock ups - Am I running it wrong?

1. "An eRA Commons ID will be required to submit a dar." <-- The eRA commons id is a link in the mock up, but seems like just text here
2. The checklist with "what are you trying to do" isn't showing up - Reading the ticket, I think it might be out of scope?

oops, you're right about the link eRA commons link! and yes, i believe there is another ticket for the 'what are you trying to do' box

[connorlbark]

note: just found a bug in the backend code for getting signing officials which breaks the frontend, investigating and will see if i can fix
edit: has been fixed in the linked backend pull request

[lu-c]

Looks good! :)

[shaemarks]

Not sure about the intended behavior, but I was able to delete my profileName and save it as empty, and then when I tried to submit a DAR, part 1 of the application wouldn't load

[shaemarks]

This is probably better suited for a different ticket, but I could only see profile name changes appear in the topleft corner of the header if I sign out and sign back in

[rushtong]

This is probably better suited for a different ticket, but I could only see profile name changes appear in the topleft corner of the header if I sign out and sign back in

I agree, we could do a better job of refreshing the user saved in storage. There are other scenarios where this happens as well, such as role additions/removals

[rushtong]

Not sure about the intended behavior, but I was able to delete my profileName and save it as empty, and then when I tried to submit a DAR, part 1 of the application wouldn't load

@connorlbark Please do add a validation check for this - we should not be setting the user name to "".

[connorlbark]

added validation to make sure the username is at least four characters (that seems reasonable to me, let me know if there is a preference for another length or just ensuring it's not empty)

[shaemarks]

I left a couple of small suggestions, but looks and works great!

[connorlbark]

added:

• validation to the signing official (makes sure it's a valid email if you're suggesting)
• updates manual on blur (so if you click off) or if you hit enter

[shaemarks]

Looks good! Thanks for the changes!