Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-1919][risk=no] MultiDataset Application Info Page - Font/UI #1680

Merged
merged 8 commits into from
Jul 19, 2022

Conversation

shaemarks
Copy link
Contributor

@shaemarks shaemarks commented Jul 15, 2022

Addresses DUOS-1919
Changes (taken from miro comments):

  • break Application Details into 3 sections:
    - Collaborators (contains: lab staff, internal collaborators, external collaborators)
    - Institution (contains: SO name/email, IT Director name/email)
    - Cloud Use (contains: anvil, local compute, cloud compute, cloud provider)
  • Switch Project title and Download icon/phrase; make DAR ID and Title all the same font as title is now

Since collaborators are optional, section title is conditionally rendered
Font size and spacing might need tweaking


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@shaemarks shaemarks marked this pull request as ready for review July 15, 2022 20:08
@shaemarks shaemarks requested a review from a team as a code owner July 15, 2022 20:08
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thank you!

Copy link
Contributor

@lu-c lu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shaemarks shaemarks merged commit 75818f1 into develop Jul 19, 2022
@shaemarks shaemarks deleted the DUOS-1919 branch July 19, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants