Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-1948][risk=no] Ignore tos if Sam does not return a userStatus object #1700

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

shaemarks
Copy link
Contributor

Addresses DUOS-1948
Changes:

  • Check before re-directing user to tos acceptance page that the userStatus object returned from Sam is not empty
  • Solution to repeated tos redirects due to Sam error

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@shaemarks shaemarks marked this pull request as ready for review July 21, 2022 20:13
@shaemarks shaemarks requested a review from a team as a code owner July 21, 2022 20:13
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

Copy link
Contributor

@lu-c lu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaemarks shaemarks merged commit 27641f4 into develop Jul 22, 2022
@shaemarks shaemarks deleted the DUOS-1948 branch July 22, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants