[DUOS-1905][risk=no] Update Researcher Console to use Summary Endpoint

[connorlbark]

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-1905

In dev, the summary endpoint does not return reference ids. We need them so that draft dar collections can be resumed. The backend change to add that is here: DataBiosphere/consent#1670

---

Have you read Terra's Contributing Guide lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[rushtong]

Not sure where the bug originates, but if I set the page count to 100 on the researcher console, I get the following error:

TypeError: Cannot read properties of undefined (reading '0')
ResearcherActions
src/components/dar_collection_table/ResearcherActions.js:48
  45 | const { collection, showConfirmationModal } = props;
  46 | const collectionId = collection.darCollectionId;
  47 | 
> 48 | const uniqueId = (collectionId ? collectionId : collection.referenceIds[0]);
     | ^  49 | 
  50 | const history = useHistory();
  51 | 

[connorlbark]

Not sure where the bug originates, but if I set the page count to 100 on the researcher console, I get the following error:

TypeError: Cannot read properties of undefined (reading '0')
ResearcherActions
src/components/dar_collection_table/ResearcherActions.js:48
  45 | const { collection, showConfirmationModal } = props;
  46 | const collectionId = collection.darCollectionId;
  47 | 
> 48 | const uniqueId = (collectionId ? collectionId : collection.referenceIds[0]);
     | ^  49 | 
  50 | const history = useHistory();
  51 | 

I'm not sure how to recreate this. I ran into the same bug when there was a bug with the consent backend; this happens in the case that there is a row which is both a draft DAR and the backend does not send a referenceId alongside it. When I create a new draft DAR locally, this doesn't happen to me. Would it be possible that there is a draft DAR in your database which does not have a referenceId? If so, that would cause this error, and I can add some guards to ensure legacy drafts don't break the UI.

[rushtong]

Would it be possible that there is a draft DAR in your database which does not have a referenceId?

This scenario should be technically impossible since all dars, draft or not, are saved with a reference id. I'll spend some time digging further now that I have some more time.

[lu-c]

im seeing some things here that i would recommend changing after merging in 1904, but we can handle that then? These variables for cancelEnabled+ were only ever used once, so I moved them to where the render was called. We can address that post merge tho! :)

[connorlbark]

sounds good to me!

[lu-c]

why did you choose to change these from collectionId to uniqueId? Was the collectionId not unique?

[connorlbark]

there isn't always a collection id. For example, if the dar collection is a draft, it doesn't have a collection id, so it would be just 'undefined' here. Thus, we need to use a referenceId in the draft case. There might be another solution here, though

[lu-c]

Sorry meant to approve this earlier, i'm working with it already in a diff branch, so it's all good :P

[rushtong]

Looks good to me. One possible improvement to consider. 👍🏽

[rushtong]

Optional suggestion. It would be nice if these string constants were part of an object/enum somewhere useful for all action-related components. Not sure where that would be for now, so definitely not a blocker for this PR.

[JVThomas]

Closing, changes already incorporated in #1699