Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-1975][risk=no] Delete component and outdated methods #1714

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

shaemarks
Copy link
Contributor

Addresses DUOS-1975


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@shaemarks shaemarks marked this pull request as ready for review July 27, 2022 20:38
@shaemarks shaemarks requested a review from a team as a code owner July 27, 2022 20:38
Copy link
Contributor

@lu-c lu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the branch locally, clicked around a little, nothing seems broken!

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@shaemarks shaemarks merged commit 9dd79fb into develop Jul 28, 2022
@shaemarks shaemarks deleted the DUOS-1975 branch July 28, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants