Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2019][risk=no] Remove SigningOfficialConsole #1750

Merged
merged 1 commit into from
Aug 15, 2022
Merged

[DUOS-2019][risk=no] Remove SigningOfficialConsole #1750

merged 1 commit into from
Aug 15, 2022

Conversation

connorlbark
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2019

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@connorlbark connorlbark marked this pull request as ready for review August 12, 2022 18:34
@connorlbark connorlbark requested a review from a team as a code owner August 12, 2022 18:34
rushtong
rushtong approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

JVThomas
JVThomas approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@JVThomas JVThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@connorlbark connorlbark merged commit 81a2f52 into develop Aug 15, 2022
@connorlbark connorlbark deleted the DUOS-2019 branch August 15, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JVThomas JVThomas JVThomas approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorlbark @rushtong @JVThomas