Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-1013][risk=no] Remove unused APIs made obsolete via MDV #1794

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[DUOS-1013][risk=no] Remove unused APIs made obsolete via MDV #1794

merged 1 commit into from
Sep 12, 2022

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Sep 8, 2022 •
edited
Loading

Addresses

Cleanup associated to https://broadworkbench.atlassian.net/browse/DUOS-1013

See also: DataBiosphere/consent#1738

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner September 8, 2022 17:29
@rushtong rushtong mentioned this pull request Sep 8, 2022
Merged
quazi-h
quazi-h approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@quazi-h quazi-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, did not observe any issues on a local UI instance.

JVThomas
JVThomas approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@JVThomas JVThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rushtong rushtong merged commit 1bfa7fd into develop Sep 12, 2022
@rushtong rushtong deleted the mdv-cleanup branch September 12, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quazi-h quazi-h quazi-h approved these changes

@JVThomas JVThomas JVThomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @JVThomas @quazi-h