Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-1958][risk=no] NIH And AnVIL Use Section #1800

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Conversation

connorlbark
Copy link
Contributor

@connorlbark connorlbark commented Sep 19, 2022

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-1958

The FormData components had matured quite a bit, so I recreated Shae's changes in a new branch to make the work simpler.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@connorlbark connorlbark marked this pull request as ready for review September 30, 2022 18:45
@connorlbark connorlbark requested a review from a team as a code owner September 30, 2022 18:45
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One syntax fix, then 👍🏽 Optionally, look into refactoring the constants for later optimization. Not required for this PR.

src/components/data_submission/NihAnvilUse.js Outdated Show resolved Hide resolved
Comment on lines +5 to +13
const I_DID = 'I Did';
const I_WILL = 'I Will';
const NO = 'No';

const nihAnvilUseLabels = {
i_did: I_DID,
i_will: I_WILL,
no: NO
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I think would be helpful is to extract all of these kinds of constants to a utility function that describes ALL of the things in a dataset registration. Later on, when the UI has access to the json schema in consent, then that utility function can be updated more easily to take advantage of existing code and reduce the duplication.

Co-authored-by: Gregory Rushton <rushtong@users.noreply.github.com>
Copy link
Contributor

@quazi-h quazi-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and the new NIH and AnVIL use section on the Dataset Registration page looks good to me.

@connorlbark connorlbark merged commit 029133f into develop Oct 11, 2022
@connorlbark connorlbark deleted the DUOS-1958-new branch October 11, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants