Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2068][risk=no] Move file type to consent group #1840

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Conversation

connorlbark
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2068


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@connorlbark connorlbark marked this pull request as ready for review October 12, 2022 19:00
@connorlbark connorlbark requested a review from a team as a code owner October 12, 2022 19:00
@rushtong
Copy link
Contributor

rushtong commented Oct 13, 2022

I'm a little confused on the implementation here. As I understand it, "Filetype" is an object with three properties, File Type, Functional Equivalence, and # of Participants. Looking at this UI, I still see the "Add New Filetype" button which, I believe, should be in the consent group box as well.

Screen Shot 2022-10-13 at 2 06 52 PM

@connorlbark
Copy link
Contributor Author

@rushtong required a decent amount of refactoring, but just got the full file type section moved to the consent group!

Copy link
Contributor

@quazi-h quazi-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fields are in the correct place now - I see the three form fields "File Type*", "Functional Equivalence*", and "# of Participants*" at the bottom of the form that appears with "Add Consent Group". Prior to this change, it was possible to select an existing consent group and also provide the file types but with these changes, adding a file type is only possible when adding a new consent group. Is this intentional?

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍🏽

@connorlbark connorlbark merged commit 5758077 into develop Oct 19, 2022
@connorlbark connorlbark deleted the DUOS-2068 branch October 19, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants