-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUOS-2125][risk=no] Add Collapsible DAC Member Vote #1844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are working well for me locally. Checked a few different DAR review pages and observed the collapsible DAC Member Votes component in the Chair and Member slabs, including the RUS slabs. The only nit I have is that the styles do not match up with the mocks on the ticket but I expect that is outside of the scope of this ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JVThomas scaled the icon, should be better now! (turns out svg scaling is kind of complicated and doesn't always work as expected... but luckily all i needed was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2125
The quick mocks show putting this section in a card, but I think the way I implemented is a bit cleaner in context of the rest of the page. Uses the same vote table as before, but updates language to make it clear that it's the dac member votes and not the chair votes. Adds the vote table to the dac member's vote page. I also added this to the member research purpose vote tab, which wasn't in the spec but seemed to be a logical need.
Have you read Terra's Contributing Guide lately? If not, do that first.