Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2125][risk=no] Add Collapsible DAC Member Vote #1844

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Conversation

connorlbark
Copy link
Contributor

@connorlbark connorlbark commented Oct 14, 2022

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2125

The quick mocks show putting this section in a card, but I think the way I implemented is a bit cleaner in context of the rest of the page. Uses the same vote table as before, but updates language to make it clear that it's the dac member votes and not the chair votes. Adds the vote table to the dac member's vote page. I also added this to the member research purpose vote tab, which wasn't in the spec but seemed to be a logical need.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@connorlbark connorlbark marked this pull request as ready for review October 14, 2022 19:24
@connorlbark connorlbark requested a review from a team as a code owner October 14, 2022 19:24
Copy link
Contributor

@quazi-h quazi-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are working well for me locally. Checked a few different DAR review pages and observed the collapsible DAC Member Votes component in the Chair and Member slabs, including the RUS slabs. The only nit I have is that the styles do not match up with the mocks on the ticket but I expect that is outside of the scope of this ticket.

Copy link
Contributor

@JVThomas JVThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but there needs to be an adjustment visually to make the dropdown icon stick out a little more. Making the sub-header and icon bigger should be a quick fix for that

Here's how it currently looks like...
Screen Shot 2022-10-18 at 8 32 04 AM

And here's how scaling up the size can help make the icon more visible...
Screen Shot 2022-10-18 at 8 23 14 AM

@connorlbark
Copy link
Contributor Author

@JVThomas scaled the icon, should be better now! (turns out svg scaling is kind of complicated and doesn't always work as expected... but luckily all i needed was !important)

Copy link
Contributor

@JVThomas JVThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorlbark connorlbark merged commit aa79221 into develop Oct 18, 2022
@connorlbark connorlbark deleted the DUOS-2125 branch October 18, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants