Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2025][risk=no] Remove IT / SO director fields from applicant information section #1848

Merged
merged 3 commits into from
Oct 26, 2022
Merged

[DUOS-2025][risk=no] Remove IT / SO director fields from applicant information section #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a090a49
remove IT / SO director
connorlbark Oct 17, 2022
b60b078
feedback
connorlbark Oct 26, 2022
8e8f542
fix tests
connorlbark Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions cypress/component/DarCollectionReview/application_information.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,48 +197,32 @@ describe('Application Information', () => {
requestSpan.contains('Person E, Person F');
});

it('renders the signing official and signing official email', () => {
it('renders the signing official and signing official', () => {
const props = {
signingOfficial: 'Person SO',
signingOfficialEmail: 'test@test.com',
};
mount(<ApplicationInformation {...props} />);
const nameLabel = cy.get('#signing-official-label');
expect(nameLabel).to.exist;
nameLabel.contains('Signing Official');

const nameSpan = cy.get('#signing-official-span');
expect(nameSpan).to.exist;
nameSpan.contains('Person SO');

const emailLabel = cy.get('#signing-official-email-label');
const emailLabel = cy.get('#signing-official-label');
expect(emailLabel).to.exist;
emailLabel.contains('Signing Official Email');
emailLabel.contains('Signing Official');

const emailSpan = cy.get('#signing-official-email-span');
const emailSpan = cy.get('#signing-official-span');
expect(emailSpan).to.exist;
emailSpan.contains('test@test.com');
});

it('renders the IT director and IT director email', () => {
it('renders the IT director and IT director', () => {
const props = {
itDirector: 'Person SO',
itDirectorEmail: 'test@test.com',
};
mount(<ApplicationInformation {...props} />);
const nameLabel = cy.get('#it-director-label');
expect(nameLabel).to.exist;
nameLabel.contains('IT Director');

const nameSpan = cy.get('#it-director-span');
expect(nameSpan).to.exist;
nameSpan.contains('Person SO');

const emailLabel = cy.get('#it-director-email-label');
const emailLabel = cy.get('#it-director-label');
expect(emailLabel).to.exist;
emailLabel.contains('IT Director Email');
emailLabel.contains('IT Director');

const emailSpan = cy.get('#it-director-email-span');
const emailSpan = cy.get('#it-director-span');
expect(emailSpan).to.exist;
emailSpan.contains('test@test.com');
});
Expand Down
8 changes: 2 additions & 6 deletions src/pages/dar_collection_review/ApplicationInformation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ export default function ApplicationInformation(props) {
isLoading = false,
externalCollaborators = [],
internalCollaborators = [],
signingOfficial = '- -',
itDirector = '- -',
signingOfficialEmail = '- -',
itDirectorEmail = '- -',
internalLabStaff = [],
Expand All @@ -127,10 +125,8 @@ export default function ApplicationInformation(props) {
];

const institutionLabels = [
{value: signingOfficial, title: 'Signing Official', key: 'signing-official'},
{value: itDirector, title: 'IT Director', key: 'it-director'},
{value: signingOfficialEmail, title: 'Signing Official Email', key: 'signing-official-email'},
{value: itDirectorEmail, title: 'IT Director Email', key: 'it-director-email'},
{value: signingOfficialEmail, title: 'Signing Official', key: 'signing-official'},
{value: itDirectorEmail, title: 'IT Director', key: 'it-director'},
];

const cloudUseLabels = [
Expand Down