Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUOS-2172[risk=no] Remove old DAR Voting and Review pages #1866

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Conversation

JVThomas
Copy link
Contributor

Addresses DUOS-2172

PR removes the old DAR voting and review pages alongside any associated ajax and helper methods (that are not used elsewhere).

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@JVThomas JVThomas marked this pull request as ready for review October 28, 2022 12:36
@JVThomas JVThomas requested a review from a team as a code owner October 28, 2022 12:36
src/libs/ajax.js Outdated
Comment on lines 431 to 417
export const Email = {

sendReminderEmail: async (voteId) => {
const url = `${await getApiUrl()}/api/emailNotifier/reminderMessage/${voteId}`;
const res = await fetchOk(url, fp.mergeAll([Config.authOpts(), { method: 'POST' }]));
return res;
}

};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a ticket in the sprint to use this function ... might not want to delete it quite yet.

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, then 👍🏽

Copy link
Contributor

@quazi-h quazi-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code removal looks good. I can no longer access the access_review or review_results pages for collections when running these changes locally.

@JVThomas JVThomas merged commit 95a7030 into develop Oct 31, 2022
@JVThomas JVThomas deleted the DUOS-2172 branch October 31, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants