Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-1501][risk=no] Add robust redirects after login #1880

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

connorlbark
Copy link
Contributor

@connorlbark connorlbark commented Nov 3, 2022

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-1501

Example cases which must redirect properly:

  • https://local.broadinstitute.org:3000/dataset_catalog should redirect to dataset catalog after logging in with an existing user.
  • https://local.broadinstitute.org:3000/home?redirectTo=dataset_catalog should redirect to dataset catalog after logging in with an existing user.
  • https://local.broadinstitute.org:3000/dataset_catalog should redirect to dataset catalog after accepting ToS with a new user.
  • https://local.broadinstitute.org:3000/home?redirectTo=dataset_catalog should redirect to dataset catalog after accepting ToS with a new user.

Can use https://consent.dsde-dev.broadinstitute.org/#/User/delete_api_user__email_ to delete a user for testing new user flow.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@connorlbark connorlbark marked this pull request as ready for review November 3, 2022 18:51
@connorlbark connorlbark requested a review from a team as a code owner November 3, 2022 18:51
@rushtong
Copy link
Contributor

rushtong commented Nov 4, 2022

I notice that the default console pages aren't being navigated to - it stays on the home page after a normal login:

Screen Shot 2022-11-04 at 11 44 52 AM

@connorlbark
Copy link
Contributor Author

I notice that the default console pages aren't being navigated to - it stays on the home page after a normal login:

👍 should be fixed now!

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Looks great!

Copy link
Contributor

@JVThomas JVThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, redirects are working well while enforcing user access rights.

@connorlbark connorlbark merged commit a440b02 into develop Nov 8, 2022
@connorlbark connorlbark deleted the DUOS-1501 branch November 8, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants