Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duos UI 2602 affiliation and roles #2290

Merged
merged 36 commits into from
Jul 21, 2023
Merged

Duos UI 2602 affiliation and roles #2290

merged 36 commits into from
Jul 21, 2023

Conversation

hams7504
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2613

Summary

  • Created affiliation and roles component
  • Added new component to main profile page
  • Removed react-bootstrap class names used for styling
  • Users should be able to edit their institution as long as they are not a signing official with an existing institution
Screenshot 2023-07-20 at 1 16 15 PM

hams7504 and others added 24 commits July 10, 2023 15:02
@hams7504
added email text field
08d0039
@hams7504
added new user page
b186a9e
@hams7504
stopped page from reloading
dcd3985
@hams7504
removed sections that are not needed
2dcdda0
@hams7504
removed all sections except name/email
bb32e0f
@hams7504
removed props
87aeb99
@hams7504
removed functions that were not needed
f704cc6
@hams7504
created user profile directory
7e26b1a
@hams7504
changed fields to read-only
91bbb68
@hams7504
used read-only form fields
30551c8
@hams7504
initialized controlled access grants page
732ea40
@hams7504
affiliation and roles
53dc056
@hams7504
completed affiliation and roles component
5abca75
@hams7504
Merge branch 'develop' into duos-2613-affiliation-and-roles
79be331
@hams7504
removed unnecessary files
2868785
@hams7504
deleted ControlledAccessGrants
bd0f91d
@hams7504
Merge branch 'develop' into duos-ui-2602-affiliation-and-roles
da0dba7
@hams7504
Update ChairConsole.js
0b45f92
@hams7504
Update ajax.js
c5ee898
@hams7504 @codacy-production
Update src/Routes.js
7645910 
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
@hams7504
Update Routes.js
2de2eb9
@hams7504
Update Routes.js
8164dd6
@hams7504 @codacy-production
Update src/Routes.js
ac911e8 
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
@hams7504 @codacy-production
Update src/Routes.js
86b2511 
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
@hams7504 hams7504 marked this pull request as ready for review July 20, 2023 18:18
@hams7504 hams7504 requested a review from a team as a code owner July 20, 2023 18:18
@hams7504 hams7504 self-assigned this Jul 20, 2023
hams7504 and others added 3 commits July 20, 2023 17:03
@hams7504
added new role component
6680ca4
@hams7504
Revert "Update src/Routes.js"
c39ddff 
This reverts commit 86b2511.
@hams7504 @codacy-production
Update src/Routes.js
5a76884 
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
kaitlynoflaherty
kaitlynoflaherty approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@kaitlynoflaherty kaitlynoflaherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Good job 😃

fboulnois
fboulnois reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question:

package.json Outdated Show resolved Hide resolved
fboulnois
fboulnois approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit that ensures that the line endings in the package-lock.json file remain LF instead of CRLF, otherwise you'll see +30k, -30k changes made to the lockfile.

Otherwise, lgtm 👍

@hams7504 hams7504 merged commit 50cec31 into develop Jul 21, 2023
@hams7504 hams7504 deleted the duos-ui-2602-affiliation-and-roles branch July 21, 2023 21:15
@rushtong rushtong mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fboulnois fboulnois fboulnois approved these changes

@kaitlynoflaherty kaitlynoflaherty kaitlynoflaherty approved these changes

Assignees

@hams7504 hams7504

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hams7504 @fboulnois @kaitlynoflaherty