Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2558] Open and controlled facet #2321

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2558

Summary

Adds the open and controlled facet to the data table


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner August 29, 2023 13:30
@fboulnois fboulnois force-pushed the fb-duos-2558-open-facet branch from f3f81e7 to 97ca32f Compare August 29, 2023 13:42
@rushtong
Copy link
Contributor

RE Styling ... I think most of the style is coming from mui controls, not index or bootstrap css files. When I disable those in the console, there is no change to them. While those files are still problematic, we might want to look more closely at the defaults that mui is adding.

Screenshot 2023-08-29 at 10 29 00 AM

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hams7504
Copy link
Contributor

RE Styling ... I think most of the style is coming from mui controls, not index or bootstrap css files. When I disable those in the console, there is no change to them. While those files are still problematic, we might want to look more closely at the defaults that mui is adding.

Screenshot 2023-08-29 at 10 29 00 AM

I had a similar issue with my MUI table where I had trouble changing the font style/color for certain parts of the table. I ended up using ThemeProvider from MUI styles to help fix that styling issue. That could be worth looking into. Specifically, I used styleOverrides: https://mui.com/material-ui/customization/theme-components/#theme-style-overrides. From the website: 'The theme's styleOverrides key makes it possible to potentially change every single style injected by Material UI into the DOM.'

Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 👍🏽

@fboulnois fboulnois merged commit bd393b0 into develop Aug 30, 2023
@fboulnois fboulnois deleted the fb-duos-2558-open-facet branch August 30, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants