Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2641][risk=no] Submitted Datasets Subtab #2322

Merged
merged 31 commits into from
Sep 19, 2023

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Aug 29, 2023

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2641

Summary

  • Remove the DS Console tab
  • Add a Submitted Datasets to the Researcher Console
  • Hide the sub nav if the user has not been granted Data Submitter role by a Signing Official
  • Disable the "Add Dataset" button if the user does not have a library card.

I suggest hiding white space - auto-formatting made a ton of unrelated changes to utils.js.

Example Screen:

Screenshot 2023-09-15 at 1 29 45 PM


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review September 14, 2023 12:45
@rushtong rushtong requested a review from a team as a code owner September 14, 2023 12:45
@rushtong rushtong changed the title WIP [DUOS-2641][risk=no] Data submitter console [DUOS-2641][risk=no] Data submitter console Sep 14, 2023
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Glad to see that the SortableTable component helped!

@rushtong rushtong changed the title [DUOS-2641][risk=no] Data submitter console [DUOS-2641][risk=no] Submitted Datasets Subtab Sep 15, 2023
Copy link
Contributor

@nmalfroy nmalfroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As a sanity check: looks like a ton of the changes are linting fixes right?

</div>
</div>
<div style={{
width: '100%',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much would it make sense to capture this in classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add a module css for this since I expect that we'll need to re-use this button style. It's already partially copied from another, unrelated page

@rushtong
Copy link
Contributor Author

Looks good. As a sanity check: looks like a ton of the changes are linting fixes right?

Yes, lots of auto-formatting changes, unfortunately.

@rushtong rushtong merged commit 57bd68d into develop Sep 19, 2023
10 checks passed
@rushtong rushtong deleted the gr-DUOS-2641-ds-datasets branch September 19, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants