-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUOS-2641][risk=no] Submitted Datasets Subtab #2322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍 Glad to see that the SortableTable component helped!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. As a sanity check: looks like a ton of the changes are linting fixes right?
</div> | ||
</div> | ||
<div style={{ | ||
width: '100%', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much would it make sense to capture this in classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to add a module css for this since I expect that we'll need to re-use this button style. It's already partially copied from another, unrelated page
Yes, lots of auto-formatting changes, unfortunately. |
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2641
Summary
I suggest hiding white space - auto-formatting made a ton of unrelated changes to
utils.js
.Example Screen:
Have you read Terra's Contributing Guide lately? If not, do that first.