Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2672] Restore a subset of dataset statistics #2343

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2672

Summary

  1. Re-hyperlink dataset names to their statistics page
  2. Remove/hide the Summary of Research Findings to Date stats boxes
  3. Remove the Status in each DAR box

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner October 2, 2023 18:56
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. To make this work locally, update the app.use block in `setupProxy.js' to be:

  app.use(
    ['/api', '/schemas', '/metrics'],
    createProxyMiddleware({
      target: configUrls.apiUrl,
      secure: false,
      pathRewrite: {
        '/api/status': '/status',
        '/api/tos/text/duos': '/tos/text/duos',
        '/metrics/dataset_statistics': '/metrics/dataset_statistics'
      }
    })
  );

Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fboulnois fboulnois merged commit e8fc999 into develop Oct 4, 2023
@fboulnois fboulnois deleted the fb-duos-2672-dataset-statistics branch October 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants