Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2723] Update Policy Pages #2366

Merged
merged 35 commits into from
Oct 26, 2023
Merged

[DUOS-2723] Update Policy Pages #2366

merged 35 commits into from
Oct 26, 2023

Conversation

hams7504
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2723

Summary

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@hams7504
implemented read only view of dar form
24b3e3f
@hams7504
exclude instructions + format component
3551d1e
@hams7504
Merge branch 'develop' into hm-duos-2608-read-only-dar-form
f9e6602
@hams7504
fixed failing tests
c3fa915
@hams7504
fixed typo
8ec2637
@hams7504
show researcher details instead of current user
0cbc40e
@hams7504
cypress testing error fix
0b5d90c
@hams7504
removed signing official field
484a930
@hams7504
revert changes to ajax.js
1cb583b
@hams7504
Revert "fixed typo"
57a9907 
This reverts commit 8ec2637.
@hams7504
Merge branch 'hm-duos-2608-read-only-dar-form' of https://github.com/…
d5ec40c 
…DataBiosphere/duos-ui into hm-duos-2608-read-only-dar-form
@hams7504
fixed code
65804f2
@hams7504
fixed typo
70a21f2
@hams7504
added collaborator list changes
f544df2
@hams7504
fix application tabs
577a55b
@hams7504
fixed instructions
22d2213
@hams7504
fix eraCommons
0a86d81
@hams7504
Rename eRACommons.js to ERACommons.js
1f77c6e
@hams7504
WIP
f0668a8
@hams7504
Merge branch 'hm-duos-2608-read-only-dar-form' of https://github.com/…
cc002a0 
…DataBiosphere/duos-ui into hm-duos-2608-read-only-dar-form
@hams7504
fixed
a9c1104
@hams7504
Rename ERACommons.js to eRACommons.js
cc10362
@hams7504
fixed
4026fd1
@hams7504
remove comments
b2decbd
@hams7504
addressed comments
08fbad9
@hams7504
fix
a64162b
@hams7504
remove alerts
3e198ca
@hams7504
update policy pages
7e06f7f
@hams7504
Merge branch 'develop' into hm-duos-ui-2723-update-policy-pages
9bc5b32
@hams7504
Update DMSPolicyInfo.jsx
39512f0
@hams7504 hams7504 marked this pull request as ready for review October 24, 2023 17:37
@hams7504 hams7504 requested a review from a team as a code owner October 24, 2023 17:37
rushtong
rushtong approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

fboulnois
fboulnois requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one recommendation:

src/pages/DMSPolicyInfo.jsx Outdated Show resolved Hide resolved
@hams7504 hams7504 requested a review from fboulnois October 25, 2023 14:05
fboulnois
fboulnois approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hams7504 hams7504 merged commit 540e8c6 into develop Oct 26, 2023
@hams7504 hams7504 deleted the hm-duos-ui-2723-update-policy-pages branch October 26, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushtong rushtong rushtong approved these changes

@fboulnois fboulnois fboulnois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hams7504 @rushtong @fboulnois