Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2799][risk=no] Fix ontology lookup #2401

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[DUOS-2799][risk=no] Fix ontology lookup #2401

merged 1 commit into from
Nov 16, 2023

Conversation

rushtong
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2799

Summary

Fixes case where ontology urls were not being looked up properly

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner November 15, 2023 20:10
fboulnois
fboulnois approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍

@fboulnois fboulnois changed the title [DUOS-2799][risk=no] Fix ontology lookup [DUOS-2779][risk=no] Fix ontology lookup Nov 15, 2023
@fboulnois fboulnois changed the title [DUOS-2779][risk=no] Fix ontology lookup [DUOS-2799][DUOS-2779][risk=no] Fix ontology lookup Nov 15, 2023
hams7504
hams7504 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@rushtong rushtong merged commit fa9654c into develop Nov 16, 2023
9 checks passed
@rushtong rushtong deleted the DUOS-2799-ontology-fix branch November 16, 2023 13:56
@rushtong rushtong changed the title [DUOS-2799][DUOS-2779][risk=no] Fix ontology lookup [DUOS-2799][risk=no] Fix ontology lookup Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hams7504 hams7504 hams7504 approved these changes

@fboulnois fboulnois fboulnois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @hams7504