Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2825] Replace institution id with name in /datalibrary/myinstitution page #2416

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

hams7504
Copy link
Contributor

@hams7504 hams7504 commented Dec 4, 2023

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2825

Summary

Screenshot 2023-12-04 at 1 55 28 PM

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@hams7504 hams7504 marked this pull request as ready for review December 4, 2023 18:55
@hams7504 hams7504 requested a review from a team as a code owner December 4, 2023 18:55
src/pages/DatasetSearch.js Outdated Show resolved Hide resolved
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment below:

src/pages/DatasetSearch.js Outdated Show resolved Hide resolved
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -48,6 +48,7 @@ export const DatasetSearch = (props) => {
const [loading, setLoading] = useState(true);
const user = Storage.getCurrentUser();
const institution = user.institution?.id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe switch this to institutionId for consistency and correctness

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@hams7504 hams7504 merged commit 02399aa into develop Dec 6, 2023
9 checks passed
@hams7504 hams7504 deleted the hm-duos-2825-replace-institution-id-with-name branch December 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants