Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2806] Fix empty columns for new study datasets #2429

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2806

Summary

Fix empty columns for new study datasets by trying all available depositor and custodian fields.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner January 5, 2024 21:42
@fboulnois fboulnois changed the title Fix empty columns for new study datasets [DUOS-2806] Fix empty columns for new study datasets Jan 5, 2024
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏽

@fboulnois fboulnois force-pushed the fb-data-depositor-custodian-creator branch 3 times, most recently from 6b0743e to 60d0aa9 Compare January 8, 2024 20:37
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois force-pushed the fb-data-depositor-custodian-creator branch from 60d0aa9 to 5b7d4c8 Compare January 9, 2024 14:13
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests look good 👍🏽

@fboulnois fboulnois force-pushed the fb-data-depositor-custodian-creator branch from 5b7d4c8 to 5fa4f66 Compare January 9, 2024 17:18
@fboulnois fboulnois merged commit d8cbb41 into develop Jan 11, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-data-depositor-custodian-creator branch January 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants