Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2966] More JSX conversions #2475

Merged
merged 15 commits into from
Mar 6, 2024
Merged

[DUOS-2966] More JSX conversions #2475

merged 15 commits into from
Mar 6, 2024

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2966

Summary

Follow up to #2397, #2438, #2470 . Switches more components from react-hyperscript-helpers to JSX.

Note: now that we are getting down to the last set of components, some of the code requires functional changes to work. Please test these out.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner March 1, 2024 18:31
@fboulnois fboulnois force-pushed the fb-duos-2966-more-jsx-4 branch 2 times, most recently from 198c822 to e067e23 Compare March 1, 2024 18:53
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! 👍🏽

Copy link

@Shakespeared Shakespeared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSX changes seem reasonable, caveat I did not test locally for functional changes

@fboulnois fboulnois merged commit b131d5a into develop Mar 6, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-duos-2966-more-jsx-4 branch March 6, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants