DCJ-367: Link to data library instead of old catalog #2615
Conversation
rushtong
requested review from
fboulnois and
okotsopoulos
and removed request for
a team
| @@ -82,7 +82,7 @@ export const headerTabsConfig = [ | |||
| link: '/admin_manage_dar_collections', | |||
| children: [ | |||
| { label: 'DAR Requests', link: '/admin_manage_dar_collections' }, | |||
| { label: 'Dataset Catalog', link: '/dataset_catalog' }, | |||
| { label: 'Data Library', link: '/datalibrary', search: 'datalibrary' }, | |||
There was a problem hiding this comment.
What does this search field represent?
There was a problem hiding this comment.
The search value is used in a couple places in this file. I don't remember exactly how it works, but I'm pretty sure it has to do with displaying the correct tab based on your role and where you have navigated to/from. For example, if you have multiple roles, each one with access to the same sub-tab (i.e. data library), then this feature helps restore the correct sub-tab when the user navigates between higher level role tabs.
| @@ -98,7 +97,6 @@ const Routes = (props) => ( | |||
| <AuthenticatedRoute path="/admin_manage_lc/" component={AdminManageLC} props={props} rolesAllowed={[USER_ROLES.admin]} /> | |||
| <AuthenticatedRoute path="/admin_manage_dar_collections/" component={AdminManageDarCollections} props={props} rolesAllowed={[USER_ROLES.admin]} /> | |||
| {checkEnv(envGroups.NON_STAGING) && <AuthenticatedRoute path="/dataset_catalog/:variant" component={CustomDatasetCatalog} props={props} rolesAllowed={[USER_ROLES.researcher]}/>} | |||
There was a problem hiding this comment.
Is this a place that also needs to be updated?
There was a problem hiding this comment.
This is the custom dataset catalog functionality in the PR description that I did not want to remove yet. Jonathan has shared out links to this so we need to figure out what to do with it.
Yes, thank you, I will get that ticket into the backlog. |
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-367
Summary
Replace all links to the old catalog page to the new data library page
This PR does not remove the older custom dataset catalog functionality. There are no in-app links to that feature but it has been shared with customers. This should be addressed in a separate ticket as a redirect feature.
Have you read Terra's Contributing Guide lately? If not, do that first.