Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-482: Safely navigate daa dac associations #2616

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jul 2, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-482

Summary

This PR fixes the existing undefined errors when trying to find the DACs on a DAA.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner July 2, 2024 16:40
@rushtong rushtong requested review from fboulnois and aarohinadkarni and removed request for a team and fboulnois July 2, 2024 16:40
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 😊

Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rushtong rushtong merged commit 6755116 into develop Jul 3, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-482-safe-daa-dac-navigation branch July 3, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants