Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCJ-486: Remove Custom Catalog #2631

Merged
merged 1 commit into from
Jul 24, 2024
Merged

DCJ-486: Remove Custom Catalog #2631

merged 1 commit into from
Jul 24, 2024

Conversation

rushtong
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-486

Summary

Remove the old custom dataset catalog page and unused code/resources

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review July 23, 2024 16:54
@rushtong rushtong requested a review from a team as a code owner July 23, 2024 16:54
@rushtong rushtong requested review from fboulnois and aarohinadkarni and removed request for a team July 23, 2024 16:54
fboulnois
fboulnois approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always good to remove code :)

aarohinadkarni
aarohinadkarni approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! yay cleanup 🥳

@rushtong rushtong merged commit 8fa2948 into develop Jul 24, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-486-rm-custom-catalog branch July 24, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarohinadkarni aarohinadkarni aarohinadkarni approved these changes

@fboulnois fboulnois fboulnois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @aarohinadkarni