Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-519: Log dataset and study selection/unselection events to Bard #2637

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

rushtong
Copy link
Contributor

Addresses

Partially addresses https://broadworkbench.atlassian.net/browse/DCJ-519

Summary

This PR adds metrics logging for selecting and unselecting datasets and studies on the data library page. It also slightly modifies the current event names to be more aligned with existing naming conventions.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review July 26, 2024 12:04
@rushtong rushtong requested a review from a team as a code owner July 26, 2024 12:04
@rushtong rushtong requested review from fboulnois, aarohinadkarni and okotsopoulos and removed request for a team July 26, 2024 12:04
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat 👍

@rushtong rushtong merged commit d08051f into develop Jul 30, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-519-dataset-study-selection branch July 30, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants