-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCJ-583: Remove boostrap and jquery #2640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-583
Summary
This PR addresses a security vulnerability in V3 Bootstrap described here: GHSA-9mvj-f7w8-pvh2. Removing bootstrap breaks all pages in the site so instead, this PR copies the most relevant bootstrap styles, minus the carousel vulnerabilities, into a separate css file. In future work, we can peel away at the bootstrap styles page by page in favor of our current usage of Material UI. This allows us to remove jquery which was a requirement for bootstrap v3.
The only functional consequences of the dynamic nature of
dropdown
related classes are in the following features:FormFieldTypes.SELECT
component that does the exact same thing and does not rely on bootstrap+jquery. This feature now works similarly to the institution selection widget on the User Profile page.Have you read Terra's Contributing Guide lately? If not, do that first.