Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-583: Remove boostrap and jquery #2640

Merged
merged 7 commits into from
Aug 13, 2024
Merged

DCJ-583: Remove boostrap and jquery #2640

merged 7 commits into from
Aug 13, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Aug 7, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-583

Summary

This PR addresses a security vulnerability in V3 Bootstrap described here: GHSA-9mvj-f7w8-pvh2. Removing bootstrap breaks all pages in the site so instead, this PR copies the most relevant bootstrap styles, minus the carousel vulnerabilities, into a separate css file. In future work, we can peel away at the bootstrap styles page by page in favor of our current usage of Material UI. This allows us to remove jquery which was a requirement for bootstrap v3.

The only functional consequences of the dynamic nature of dropdown related classes are in the following features:

  • Header Profile Navigation: The displayed username in the right-most nav link used this to show a dropdown with links to the user's profile and signing out. This was replaced with a simple state variable.
  • Manage DAAs: This PR introduces a breaking change to the "Add All Users to DAC" dropdown. This feature will be replaced with "Add All Users to DAA" so I am accepting this as new technical debt for a feature that is not released to production yet.
  • Admin Manage User: The institution selection widget is replaced with an existing FormFieldTypes.SELECT component that does the exact same thing and does not rely on bootstrap+jquery. This feature now works similarly to the institution selection widget on the User Profile page.
  • SO Add Library Card User: This feature is essentially unreachable right now and can be ignored.

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review August 8, 2024 16:02
@rushtong rushtong requested a review from a team as a code owner August 8, 2024 16:02
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team August 8, 2024 16:02
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unused

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🎉

Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rushtong rushtong merged commit 60c2d5e into develop Aug 13, 2024
9 checks passed
@rushtong rushtong deleted the gr-npm-audit-fix branch August 13, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependencies npm security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants