DCJ-619: Simplify/fix useEffect infinite reload problem

[rushtong]

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-619

Summary

This PR does a few of things that hopefully clarify and simplify the intended functionality behind this page.

1. Move all initialization logic into a single method
2. Load DACs based on the user role. Here, we check state to see if the user is Admin before loading all DACs on the page. This prevents a flash of seeing all DACs before they get filtered by role and instead, only become visible once state has loaded and we know which role the user is accessing DACs for.
3. Clean up usages of lodash to use native javascript filter/map/includes functionality
4. Reduce the useEffect dependencies to an empty array

---

Have you read Terra's Contributing Guide lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[fboulnois]

good catch 👍

[pshapiro4broad]

The change looks OK but client side filtering based on role always makes me nervous. I assume that it's OK that a user can see all DACs even if they can't operate on them? So the filtering isn't for security, but to hide elements in the UI that would otherwise be disabled?

[rushtong]

The change looks OK but client side filtering based on role always makes me nervous. I assume that it's OK that a user can see all DACs even if they can't operate on them? So the filtering isn't for security, but to hide elements in the UI that would otherwise be disabled?

Yes exactly, all DACs are visible to all users. The APIs, of course, enforce role based restrictions as well.