Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-629: Bug Fix for DAA Route Logic #2653

Merged
merged 2 commits into from
Aug 26, 2024
Merged

DCJ-629: Bug Fix for DAA Route Logic #2653

merged 2 commits into from
Aug 26, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Aug 23, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-629

Summary

Minor bug fix to allow for a route when DAA functionality is enabled

Requires #2654 for GHA to pass


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner August 23, 2024 18:37
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team August 23, 2024 18:37
@rushtong
Copy link
Contributor Author

See #2654 for npm fix

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@rushtong rushtong merged commit 0a857f6 into develop Aug 26, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-629-fix-route branch August 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants