[DT-902] Replace DAC Column with Data Use Column in Data Library Dataset Table #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinyecai
requested review from
rushtong and
snf2ye
and removed request for
a team
cinyecai
commented
Oct 31, 2024
| label: `DAC for dataset ${dataset.datasetId}: ${dataset.dac?.dacName}` | ||
| }) | ||
| cellStyle: makeHeaderStyle(cellWidths.dataUse), | ||
| cellDataFn: (dataset: DatasetTerm) => { |
There was a problem hiding this comment.
This whole function reuses the Data Use logic used on the DAC Datasets table (in the file DACDatasetTableCellData.jsx) to maintain consistency in how each table's Data Use column behaves/looks. It's not as clean as the other cellDataFn's in this file so I'm open to feedback/suggestions on what to do here if this isn't the best approach
There was a problem hiding this comment.
Update - Adjusted to using helper function instead
There was a problem hiding this comment.
I think that's okay. I would rather it be different here than duplicate the logic in multiple places.
fboulnois
approved these changes
Nov 1, 2024
s-rubenstein
approved these changes
Nov 1, 2024
| label: `DAC for dataset ${dataset.datasetId}: ${dataset.dac?.dacName}` | ||
| }) | ||
| cellStyle: makeHeaderStyle(cellWidths.dataUse), | ||
| cellDataFn: (dataset: DatasetTerm) => { |
There was a problem hiding this comment.
I think that's okay. I would rather it be different here than duplicate the logic in multiple places.
snf2ye
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-902
Summary
Replaces the DAC column in the Data Library Dataset table with a Data Use column
Column displays Data Use codes (primary and secondary) and has a tooltip explaining each code when you hover over that cell in the table
Screen.Recording.2024-10-31.at.4.19.40.PM.mov
Have you read Terra's Contributing Guide lately? If not, do that first.