Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-959: DAC Unit Tests #2709

Merged
merged 15 commits into from
Nov 5, 2024
Merged

DT-959: DAC Unit Tests #2709

merged 15 commits into from
Nov 5, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Nov 4, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DT-959

Summary

This PR:

  • Adds unit tests for the following components
    • EditDac.jsx which is the newest version that supports DAAs
    • ManageEditDac.jsx which is the original version that does not have DAA support, but is still in production use.
    • DacUsers.jsx which is the subcomponent that shows existing/selected chairpersons or members
  • Adds tsconfig support for importing json files
  • Adds eslint support for single quote warning in jsx files
  • Formatting changes to the tested files to apply existing lint rules.

Note to testers, I suggest hiding whitespace when reviewing due to the large number of formatting changes. There are no functional changes to any of the components under test.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review November 5, 2024 12:58
@rushtong rushtong requested a review from a team as a code owner November 5, 2024 12:58
@rushtong rushtong requested review from snf2ye and s-rubenstein and removed request for a team November 5, 2024 12:58
Copy link

@snf2ye snf2ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@rushtong rushtong merged commit 1f4568c into develop Nov 5, 2024
9 checks passed
@rushtong rushtong deleted the gr-DT-959-unit-tests branch November 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants