Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-779] Clear selected filters code #2725

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

s-rubenstein
Copy link
Contributor

Addresses

Adds a clear filters button

Summary

Screen.Recording.2024-11-14.at.10.59.10.AM.mov

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@s-rubenstein s-rubenstein requested a review from a team as a code owner November 14, 2024 15:59
@s-rubenstein s-rubenstein requested review from rushtong and fboulnois and removed request for a team November 14, 2024 15:59
@rushtong
Copy link
Contributor

I think this interferes with the search bar. If I enter a value there and clear the search, the dataset list remains unchanged.

@s-rubenstein
Copy link
Contributor Author

Good call! Clear search definitely seems affected. I'll poke around

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍🏽

src/components/data_search/DatasetFilterList.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search no longer works as expected:

  1. Enter a keyword like "All"
  2. Clicking "Clear Search" has no effect
  3. Manually removing the search text has no effect

@s-rubenstein
Copy link
Contributor Author

@fboulnois that is not what I see on my local - maybe we can verify we are running the same version?

@s-rubenstein
Copy link
Contributor Author

Screen.Recording.2024-11-14.at.3.45.27.PM.mov

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s-rubenstein s-rubenstein merged commit dcbcf31 into develop Nov 15, 2024
9 checks passed
@s-rubenstein s-rubenstein deleted the sr/dt-779-clear-filters branch November 15, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants