-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DT-779] Clear selected filters code #2725
Conversation
I think this interferes with the search bar. If I enter a value there and clear the search, the dataset list remains unchanged. |
Good call! Clear search definitely seems affected. I'll poke around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The search no longer works as expected:
- Enter a keyword like "All"
- Clicking "Clear Search" has no effect
- Manually removing the search text has no effect
@fboulnois that is not what I see on my local - maybe we can verify we are running the same version? |
Screen.Recording.2024-11-14.at.3.45.27.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Addresses
Adds a clear filters button
Summary
Screen.Recording.2024-11-14.at.10.59.10.AM.mov
Have you read Terra's Contributing Guide lately? If not, do that first.