[DT-688] Disable DUOS sign-in when Sam is down #2763
Conversation
fboulnois
force-pushed
the
fb-dt-688-check-sam-down
branch
from
9873d6b to
4b1b8a1
Compare
| beforeEach(() => { | ||
| cy.initApplicationConfig(); | ||
| cy.stub(ServiceStatus, 'getConsentStatus').resolves(consentStatus); |
There was a problem hiding this comment.
For some reason if I add this to the tests instead, the tests fail. This is very mysterious cypress behavior to me.
fboulnois
changed the title
fboulnois
requested review from
pshapiro4broad and
rjohanek
and removed request for
a team
| const init = async () => { | ||
| setIsSamDown(!(await ServiceStatus.isSamHealthy())); | ||
| }; |
There was a problem hiding this comment.
why use a useEffect with no dependencies, instead of a onMount?
There was a problem hiding this comment.
That is the recommended mechanism when using modern React, it's equivalent to an onMount: https://react.dev/learn/synchronizing-with-effects#step-3-add-cleanup-if-needed
|
|
||
| class Status extends Component { |
There was a problem hiding this comment.
I see you've refactored this component a bit; are we moving away towards extending Conponent?/Is this a step towards typescriptifying?
There was a problem hiding this comment.
Yes and yes, this is the old React style, we have moved to a more functional style (export const Thing = (props) => { ... return (...) };).
See Summary section above. |
Thanks! Is it useful to say "Sam"? Will that mean anything to users? Are there mocks for this? |
I don't think we have mocks and I'm not sure about the messaging, I reused Cinye's design for the UI aspect. |
Maybe we could ask Lou, or use more broad language like "authentication" |
Addresses
https://broadworkbench.atlassian.net/browse/DT-688
Summary
Takes the UI design from: https://github.com/DataBiosphere/duos-ui/tree/cc-dt-688-disable-ui-when-sam-down
Have you read Terra's Contributing Guide lately? If not, do that first.