-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DUOS-762[risk=no] Added Cancel Button to New Chair Console #887
Conversation
…on to create shared view update helper function for both create and cancel flows
…heck for vote check on filter, added key attribute to button elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functions great! I am confused about the implementation of side-by-side buttons:
The invision spec shows a cancel icon, not a button:
I don't see any discussion of this in the associated story. Can we touch base on this and maybe get feedback from @solideoglori on how we chose to implement the differences?
The codacy checks here are invalid and should be ignored. |
They're all supposed to be icon/buttons with custom styles. I'd figured it'll be best to get the functionality done now and implement the styling in another PR once it's all set up. |
Ah, gotcha. In that case, 👍🏽 |
Leaving a note that the current npm audit flag (regarding immer dependency in react-scripts) is a false positive Vulnerability regarding react-responsive-navbar has been handled by DUOS-810 #885 |
Addresses DUOS-762
PR aims to add Cancel button to the New Chair Console. Code also splits up some helper methods in NewChairConsole so that it can be used in both create and cancel workflows. Code also refactors legacy code as a result of returning res.json on the createDARElection ajax method, which is used in NewChairConsole. Finally, code adds minor templating for Vote/Final conditional rendering.
Have you read Terra's Contributing Guide lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: