Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUOS-762[risk=no] Added Cancel Button to New Chair Console #887

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

JVThomas
Copy link
Contributor

@JVThomas JVThomas commented Feb 18, 2021

Addresses DUOS-762

PR aims to add Cancel button to the New Chair Console. Code also splits up some helper methods in NewChairConsole so that it can be used in both create and cancel workflows. Code also refactors legacy code as a result of returning res.json on the createDARElection ajax method, which is used in NewChairConsole. Finally, code adds minor templating for Vote/Final conditional rendering.

Have you read Terra's Contributing Guide lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • PR is labeled with a Jira ticket number and includes a link to the ticket
  • PR is labeled with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes

In all cases:

  • Get a minimum of one thumbs worth of review, preferably 2 if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this
  • Test this change deployed correctly and works on dev environment after deployment

@JVThomas JVThomas requested a review from a team as a code owner February 18, 2021 13:46
…heck for vote check on filter, added key attribute to button elements
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functions great! I am confused about the implementation of side-by-side buttons:

Screen Shot 2021-02-19 at 12 17 57 PM

The invision spec shows a cancel icon, not a button:

Screen Shot 2021-02-19 at 12 24 49 PM

I don't see any discussion of this in the associated story. Can we touch base on this and maybe get feedback from @solideoglori on how we chose to implement the differences?

@rushtong
Copy link
Contributor

The codacy checks here are invalid and should be ignored.

@JVThomas
Copy link
Contributor Author

JVThomas commented Feb 19, 2021

This functions great! I am confused about the implementation of side-by-side buttons:

Screen Shot 2021-02-19 at 12 17 57 PM

The invision spec shows a cancel icon, not a button:

Screen Shot 2021-02-19 at 12 24 49 PM

I don't see any discussion of this in the associated story. Can we touch base on this and maybe get feedback from @solideoglori on how we chose to implement the differences?

They're all supposed to be icon/buttons with custom styles. I'd figured it'll be best to get the functionality done now and implement the styling in another PR once it's all set up.

@rushtong
Copy link
Contributor

They're all supposed to be icon/buttons with custom styles. I'd figured it'll be best to get the functionality done now and implement the styling in another PR once it's all set up.

Ah, gotcha. In that case, 👍🏽

@JVThomas
Copy link
Contributor Author

JVThomas commented Feb 22, 2021

Leaving a note that the current npm audit flag (regarding immer dependency in react-scripts) is a false positive
facebook/create-react-app#10412 (comment)

Vulnerability regarding react-responsive-navbar has been handled by DUOS-810 #885

@JVThomas JVThomas merged commit c0ac6e5 into develop Feb 22, 2021
@JVThomas JVThomas deleted the DUOS-762 branch February 22, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants