Skip to content

Commit

Permalink
Update to from node 14->16
Browse files Browse the repository at this point in the history
Fixes build issue with vite
  • Loading branch information
samanehsan committed Aug 22, 2023
1 parent 92c71a7 commit 2d265f2
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
timeout-minutes: 180
strategy:
matrix:
node-version: [14.x]
node-version: [16.x]
if: "!contains( github.event.pull_request.labels.*.name, 'skip-ci')"
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
timeout-minutes: 180
strategy:
matrix:
node-version: [14.x]
node-version: [16.x]
if: "!contains( github.event.pull_request.labels.*.name, 'skip-ci')"
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
node-version: [14.x]
node-version: [16.x]
if: "!contains( github.event.pull_request.labels.*.name, 'skip-ci')"
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN /usr/local/bin/docker-entrypoint.sh generate -g typescript-axios -i $TDR_OPE


## Step 2. Build the deployable UI artifacts
FROM node:14.0-buster as build
FROM node:16.20-buster as build
# Check out the build
RUN set -x \
&& git clone https://github.com/DataBiosphere/jade-data-repo-ui \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.direct
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ARG TDR_OPEN_API_YAML_LOCATION
RUN /usr/local/bin/docker-entrypoint.sh generate -g typescript-axios -i $TDR_OPEN_API_YAML_LOCATION -o /local/src/generated/tdr --skip-validate-spec

## Step 2. Build the deployable UI artifacts
FROM node:14.0-buster as build
FROM node:16.20-buster as build
# Copy the local code
COPY . /
# Copy the generated code
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ rm -R ~/.avn (if you want to reset an existing or failed avn setup)
nvm exec 10.0.0 npm install -g avn avn-nvm avn-n
nvm exec 10.0.0 avn setup
nvm install lts/erbium --default
nvm use lts/erbium
nvm use lts/gallium
```

- Run `npm install` to download dependencies defined in the package.json file and generate the node_modules folder with the installed modules.
Expand Down Expand Up @@ -61,14 +61,14 @@ gcloud auth login --no-activate

### Development

- webpack-dev-server 3.x
- vite-dev-server 5.x
- redux-devtools (with browser plugin)

`npm start`

### Building

- webpack 4.x
- vite 4.x
- babel 7.x

`npm run build`
Expand All @@ -82,7 +82,7 @@ gcloud auth login --no-activate

### Testing

- cypress 9.x
- cypress 12.x

To run end-to-end tests: `npx cypress run` or `npx cypress open` (interactive mode)

Expand Down

0 comments on commit 2d265f2

Please sign in to comment.